Conversation
aeharding
changed the title
aeharding
force-pushed
the
reader-mode
branch
from
e08e9d6 to
d6ad9ab
Compare
giralte-ionic
requested review from
IT-MikeS,
ItsChaceD,
OS-martacarlos,
alexgerardojacinto and
hectorjdgdev
|
Is there any help needed on this PR? I'd love to see this merged in |
|
Any chancre of seeing this one being merged in? I've tested the patch and it seems to work great. Would be good to not have to hold a patch locally. |
| | **`presentationStyle`** | <code>'fullscreen' \| 'popover'</code> | iOS only: The presentation style of the browser. Defaults to fullscreen. Ignored on other platforms. | 1.0.0 | | ||
| | **`width`** | <code>number</code> | iOS only: The width the browser when using presentationStyle 'popover' on iPads. Ignored on other platforms. | 4.0.0 | | ||
| | **`height`** | <code>number</code> | iOS only: The height the browser when using presentationStyle 'popover' on iPads. Ignored on other platforms. | 4.0.0 | | ||
| | **`entersReaderIfAvailable`** | <code>boolean</code> | iOS only: Whether to automatically enter Reader mode if available for the url Ignored on other platforms. | 4.0.0 | |
There was a problem hiding this comment.
| | **`entersReaderIfAvailable`** | <code>boolean</code> | iOS only: Whether to automatically enter Reader mode if available for the url Ignored on other platforms. | 4.0.0 | | |
| | **`entersReaderIfAvailable`** | <code>boolean</code> | iOS only: Whether to automatically enter Reader mode if available for the url. Ignored on other platforms. | 4.0.0 | |
| * | ||
| * Ignored on other platforms. | ||
| * | ||
| * @since 5.0.0 |
There was a problem hiding this comment.
| * @since 5.0.0 | |
| * @since 8.x.y or whatever version is correct |
|
Thanks for opening this PR 🙏 As part of our backlog maintenance effort, we’re reviewing older pull requests for compatibility with the current branch structure and latest releases. Details: https://ionic.io/blog/keeping-capacitors-backlog-healthy This PR will need to be rebased against the latest main branch and updated to resolve merge conflicts. If we don’t see updates within 7 days, we’ll close it to keep the queue focused — but it can always be resubmitted once updated. |
|
@aeharding do you have time to rebase this on the latest commit? Otherwise I can open a new PR |
|
@derme302 I think the capacitor-plugins browser API is frozen, and the capacitor team is invested in https://github.com/ionic-team/capacitor-os-inappbrowser which has an enters reader mode option. So I might just close this one! |
5 participants
Resolves #447